Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve various warnings #772

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Oct 8, 2024

This PR cleans up all existing warnings and a few tiny bugs, the radix-ui upgrade added some warnings so I thought it was a good time for this.

  • all apps
    • Fixed a warning caused by animation props being passed to non-animated graphs.
    • Fixed warnings around dialog description and aria-describedby.
      • The Dialog now supports providing a title or description that is visually hidden but still announced by assistive technology.
      • Added explicit aria descriptions to some primary dialogs.
    • Adjusted tooltip to only wrap content with Paragraph if prop is a string or React.Fragment.
    • Fixed instances/warnings where content included div elements which are not allowed inside a p.
    • Fixed a 1 pixel gap that would show between the top of the Table and its sticky header when scrolling.
  • renterd
    • Fixed an issue with the uploads list loading and empty states.
  • walletd
    • Fixed an issue where the app would try to fetch from an invalid URL when first initializing.
    • There is a duplicate key warning in the walletd transactions list, this was caused by a walletd bug which is now fixed, no change required.
  • website
    • Added a max height and radius for hosts on the host map.
    • Fixed hydration mismatch warnings related to the random selection of a host on the globe.
    • Fixed a hydration mismatch warning related to the ThemeRadio in footer.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hostd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 5:54pm
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 5:54pm
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 5:54pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 5:54pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 5:54pm

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: ac1c523

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
website Patch
@siafoundation/design-system Minor
renterd Patch
walletd Patch
hostd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

alexfreska commented Oct 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@alexfreska alexfreska mentioned this pull request Oct 8, 2024
@alexfreska alexfreska force-pushed the chore_resolve_various_warnings branch from b46fbd5 to 9c85c9d Compare October 8, 2024 18:32
@alexfreska alexfreska force-pushed the chore_resolve_various_warnings branch 2 times, most recently from c2eede2 to fe68205 Compare October 8, 2024 18:52
@alexfreska alexfreska force-pushed the chore_resolve_various_warnings branch from fe68205 to ed8ac3c Compare October 8, 2024 19:53
@alexfreska alexfreska force-pushed the chore_resolve_various_warnings branch from ed8ac3c to d03e7bd Compare October 10, 2024 20:31
@alexfreska alexfreska force-pushed the chore_resolve_various_warnings branch from d03e7bd to b23be9c Compare October 10, 2024 21:20
@alexfreska alexfreska force-pushed the chore_resolve_various_warnings branch from b23be9c to 2fe46f0 Compare October 10, 2024 21:27
Copy link
Member Author

alexfreska commented Oct 11, 2024

Merge activity

  • Oct 11, 1:37 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 11, 1:40 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 11, 1:41 PM EDT: A user merged this pull request with Graphite.

Base automatically changed from chore_upgrade_radix to main October 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants